[Differential] [Accepted] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Sun Oct 9 22:02:08 UTC 2016


davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pritambaral wrote in SessionManagementScreen.qml:89-90
> It isn't. `Layout.alignment` controls alignment of the Label element, `horizontalAlignment` controls alignment of the //text within// the Label element.
> 
> I could replace `Layout.alignment: Qt.AlignHCenter` with `anchors.horizontalCenter: parent.horizontalCenter`; they have the same effect.

Oh, because even though it has fillWidth: true we still have a Layout.maximumWidth so we do need both.

This is fine.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma, davidedmundson
Cc: davidedmundson, jensreuterberg, pritambaral, plasma-devel, lesliezhai, ali-mohamed, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161009/5d7610cf/attachment.html>


More information about the Plasma-devel mailing list