[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

[pritambaral (Pritam Baral)]

pritambaral added a comment.


  Oddly enough, setting `anchors` instead of `Layout` does fix one of the original issues; the one about word wrap wrongly triggering when there is room available on the first line. I guess the `Layout.alignment` line @davidedmundson pointed out is in fact the cause of trouble. Maybe I should revise the revision; will run a few tests with some arbitrary font, font size, and DPI values.

INLINE COMMENTS

> davidedmundson wrote in SessionManagementScreen.qml:89-90
> Then this line is redundant

It isn't. `Layout.alignment` controls alignment of the Label element, `horizontalAlignment` controls alignment of the //text within// the Label element.

I could replace `Layout.alignment: Qt.AlignHCenter` with `anchors.horizontalCenter: parent.horizontalCenter`; they have the same effect.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2984

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: pritambaral, #plasma
Cc: davidedmundson, jensreuterberg, pritambaral, plasma-devel, lesliezhai, ali-mohamed, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161009/4395a56b/attachment.html>