[Differential] [Request, 18 lines] D2990: Fix circular logic causing Pager to remain hidden

hein (Eike Hein) noreply at phabricator.kde.org
Sun Oct 9 09:45:46 UTC 2016


hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  The Pager applet would transition to HiddenStatus if PagerModel.count
  was smaller than 2, however hiding the root item would set
  PagerModel.enabled to false, dropping the count to 0 and stopping
  the window system monitoring, thus never transitioning the applet
  back to ActiveStatus if the desktop or activity count increased again.
  
  This patch introduces a new PagerModel.shouldShowPager property which
  is updated even when the model is disabled, then used to drive both the
  applet status and the enabled state of the model.
  
  BUG:370324

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2990

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161009/072e81c1/attachment.html>


More information about the Plasma-devel mailing list