[Differential] [Commented On] D2967: delete containments upon activity deletion

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2967#55233, @davidedmundson wrote:
  
  > But it also tracks them and deletes when an object is removed:
  > ShellCorona::desktopContainmentDestroyed
  >
  > If you manually do it as well you're throwing all sense of a  design pattern out the window and having it sometimes update the list before removal, sometimes after. Inconsistencies lead to bugs.
  
  
  ugh, i didn't remember that (that's what reviews are for, eh ;) fixed now

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2967

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, ivan, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161007/8fd47221/attachment.html>