[Differential] [Commented On] D2972: Allow configuring script's screen edges from the KCM

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:212
> it's copy paste from kcm_kwinscripts
> 
> If you are doing that in kwin you have a bug as you're ignoring the KWin-Exclude-Listing flag and potentially loading things that you can't configure.

> If you are doing that in kwin you have a bug as you're ignoring the KWin-Exclude-Listing flag and potentially loading things that you can't configure.

KWin-Exclude-Listing is for the KCM to not show them IIRC, but not for KWin. Anyway the KCMs need to be ported to KPackage, it's just legacy, let's not add more porting work to new code. I would appreciate if that could be changed to packages here.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2972

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161007/3f2a3700/attachment.html>