[Differential] [Commented On] D2972: Allow configuring script's screen edges from the KCM

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in main.cpp:212
> Why are you querying KService? Scripts are packages and at least KWin internally they are queried using:
> 
>   KPackage::PackageLoader::self()->listPackages(QStringLiteral("KWin/Script"), scriptFolder);

it's copy paste from kcm_kwinscripts

If you are doing that in kwin you have a bug as you're ignoring the KWin-Exclude-Listing flag and potentially loading things that you can't configure.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2972

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161007/365c0993/attachment-0001.html>