Review Request 129110: Generate the icon into the appstream file

Aleix Pol Gonzalez aleixpol at kde.org
Thu Oct 6 11:11:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129110/
-----------------------------------------------------------

(Updated Oct. 6, 2016, 11:11 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Matthias Klumpp.


Changes
-------

Submitted with commit 435795224c2ac2f9b358d1b3588de80e356d40c5 by Aleix Pol to branch master.


Repository: kpackage


Description
-------

Provide the icon name for now, maybe at some point it makes sense to do something fancier.


Diffs
-----

  autotests/data/testpackage/metadata.desktop 36a861f 
  autotests/data/testpackage/testpackage.testappdataxml 7750a33 
  src/kpackagetool/kpackagetool.cpp be492b3 

Diff: https://git.reviewboard.kde.org/r/129110/diff/


Testing
-------

tests pass, even with the addition.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161006/cdbc591d/attachment.html>


More information about the Plasma-devel mailing list