[Differential] [Commented On] D2945: Workaround xkbcommon behavior concerning consumed modifiers

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> luebking wrote in keyboard_input.cpp:420
> Possible pitfalls:
> 
> What if eg. Ctrl+Alt+Foo creates a keysym, but Ctrl+Alt+Shift+Foo does not?
> 
> If however Ctrl+Alt+Foo and Ctrl+Alt+Shift+Foo create keysyms, Ctrl+Alt+Shift would be consumed but Ctrl+Alt should be considered consumed as well (so this test fails), right?
> 
> -> should one test for equality to rule out at least case one?

Equality doesn't work: Alt+F3 consumes ctrl+Alt, but only alt is pressed.

REPOSITORY
  rKWIN KWin

BRANCH
  consumed-mods-fix-5.8

REVISION DETAIL
  https://phabricator.kde.org/D2945

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161006/61d127bd/attachment.html>