[Differential] [Request, 3 lines] D2954: [Notification Data Engine] Don't group notification if it should replace an existing one

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Oct 6 08:01:49 UTC 2016


broulik created this revision.
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If an application explicitly requests a notification to replace another one (replaces_id set), don't group it with another notification.
  
  When creating a KNotification object and then updating it by calling e.g. setText it would just append it to the already shown notification.

TEST PLAN
  Applied https://phabricator.kde.org/D2942 and I now only get one notification which is updated
  
  (when I press the klipper shortcut again after the popup has closed, it doesn't work again, dunno if that's related to this patch or some other issue :/)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2954

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mck182
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161006/a461286a/attachment.html>


More information about the Plasma-devel mailing list