[Differential] [Accepted] D2946: make sure allTimezones is set

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Wed Oct 5 14:51:46 UTC 2016


broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  So they changed the behavior of QQmlPropertyMap when a property is inserted that previously didn't exist?

INLINE COMMENTS

> main.qml:45
> +    function initTimezones() {
> +        var tz  = Array()
> +        if (plasmoid.configuration.selectedTimeZones.indexOf("Local") === -1) {

Prefer [] over Array()

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/inittimezones

REVISION DETAIL
  https://phabricator.kde.org/D2946

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161005/2de5161d/attachment.html>


More information about the Plasma-devel mailing list