[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  If there isn't an option for that already (haven't checked) might make sense to turn that notification into a proper notifyrc event, so the user can turn the notification off. (separate to this patch, obviously)

INLINE COMMENTS

> klipper.cpp:239
> +                m_notification = KNotification::event(KNotification::Notification, caption, text,
> +                                                    QIcon::fromTheme(QStringLiteral("klipper")).pixmap(QSize(16, 16)));
> +            }

There's an overload that takes a QString iconName which avoids hardcoding the icon size and sending a pixmap over dbus.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2942

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161005/5065d458/attachment.html>