Review Request 129096: Check defaultActionsCfg is valid

David Edmundson david at davidedmundson.co.uk
Tue Oct 4 21:09:21 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129096/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 11:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 0f2bc677b9bddb83d68b5d4d5241f48c31c30735 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

Commit 752626ad550552232d73d8b009db62b0f8e86113 left a code path through
the switch statement where defaultActionsCfg would be an invalid group.

This is semantically correct as there is no relevant actions config for
this type of containment, however we then call methods on that config group which leads to an assert - and a failing unit test.


Diffs
-----

  src/plasma/containment.cpp dde5dd366d56147ca3d24badb17a8639c833285b 

Diff: https://git.reviewboard.kde.org/r/129096/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161004/955e43f0/attachment.html>


More information about the Plasma-devel mailing list