[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

[mart (Marco Martin)]

mart added a comment.


  I like the idea, but i am a bit concerned about the added complexity, that may be worked around?

INLINE COMMENTS

> NotificationItem.qml:318
> +
> +        ListView {
> +            id: previewList

the main concern i have, is the general weight of QML.
this is going to make worse both memory usage and time to instantiate the notification item, regarless if the notification has urls or not...
idea: could all of this part be in a loader that actually parses the component and instantiates the whole listview only if there is at least one url?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161130/81729a73/attachment.html>