[Differential] [Updated, 374 lines] D3539: [Notifications] Show interactive thumbnails on notifications

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Wed Nov 30 09:36:13 UTC 2016


broulik updated this revision to Diff 8625.
broulik added a comment.


  - Reduce preview area in height (now 1/3 of the dialog width instead of 1/2 as before – I tried 1/4 but given the aspect ratio it would make the preview hard to see imho)
  - When there is one item but a preview could not be generated show it as regular sized file instead of huge file icon
  - Use PlasmaCore.IconItem for the icon instead of having the Previewer generate a pixmap off the theme icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3539?vs=8608&id=8625

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161130/a3368e49/attachment.html>


More information about the Plasma-devel mailing list