[Differential] [Request, 37 lines] D3528: Select correct index without timer

mart (Marco Martin) noreply at phabricator.kde.org
Mon Nov 28 12:03:21 UTC 2016


mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
    remove the timer that selects the index at startup
    that caused flickering and things moving around since
    index 0 got selected, then moved to the correct one only after a while.
    
    unfortunately there is not a place (a signal) that says
    "the view has been correctly instanced from the model" that
    would be where selecting the current index at startup would be the safest.
    a place that seems working correctly is on listview onCountChanged
    
    this has to introduce KCMLookandFeel::selectedPluginIndex
    that isn't very pretty, but the flickering seems to be gone and
    the kcm loads from the correct place of the view from the first
    frame is displayed

TEST PLAN
  he flickering seems to be gone and the kcm loads from the correct place of the view from the first frame is displayed. Once this is in the final form, some other config dialogs need the same treatment: plasma theme and wallpapers

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/selectindex

REVISION DETAIL
  https://phabricator.kde.org/D3528

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161128/f6925693/attachment.html>


More information about the Plasma-devel mailing list