[Differential] [Commented On] D3472: API for window tabbing

[chinmoyr (Chinmoy Ranjan Pradhan)]

chinmoyr added a comment.


  > what's an "Op"?
  
  Op = Operation
  
  > If you need to know whether a mouse button should start the drag, use the settings.
  
  By "use the settings" do you mean moving "*Op" methods to DecorationSettings??
  
  > why do you go through the DecoratedClient? You have the d->windowTabs you can derive the number from?
  
  If you think the logic of "createDecorationTab" is fine then the "tabCount" method can be safely removed.
  
  > Once the DecorationTab got activated this method is returning an incorrect value. It caches the active state of the client, but never updates again.
  
  When say 'n' clients are tabbed, 'n' tabs are painted on the titlebar of each client (i.e. total of n^2 tabs are created). In each client one tab which represents the client has m_active set to true and for rest of the tabs m_active is false.
  So updating m_active is not required.

REPOSITORY
  rKDECORATION Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D3472

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, graesslin, #kwin, #plasma
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161127/44ae1deb/attachment.html>