[Differential] [Request, 3 lines] D3519: Move updating of primary screen in screenpool after fetching its id

[jakubgocol (Jakub Gocoł)]

jakubgocol created this revision.
jakubgocol added a reviewer: Plasma.
jakubgocol set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We need old id of new primary screen. After we update primary screen in screenpool, it will always return id = 0. It causes invalid m_desktopViewforId mapping and  panel doesn't move next time when we change primary screen.

TEST PLAN
  Preconditions:
  Computer with 1 display, running plasmashell
  
  Test steps:
  
  1. Connect one external screen (first screen is primary)
  2. Change primary screen to second screen
  3. Change primary screen back to first screen
  4. Unplug second screen
  
  Expected:
  In step 3 panel moves to first screen
  In step 4 plasmashell keeps running
  
  Actual (before change):
  In step 3 panel remains on second display
  In step 4 plasmashell crashes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3519

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jakubgocol, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161126/76bae162/attachment.html>