[Differential] [Requested Changes To] D3499: drm cursor scaling

[graesslin (Martin Gräßlin)]

graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> drm_output.cpp:93-94
>  {
>      const QPoint p = globalPos - m_globalPos;
> -    drmModeMoveCursor(m_backend->fd(), m_crtcId, p.x(), p.y());
> +    drmModeMoveCursor(m_backend->fd(), m_crtcId, p.x() * m_scale, p.y() * m_scale);
>  }

that just cannot work in a multi screen setup. The global pos is in combined coordinates and you apply here a scale for a single screen.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3499

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161125/ed5ba3a5/attachment.html>