[Differential] [Changed Subscribers] D3494: Set m_client size in global compositor co-ordinatesKWin wants to deal with the post-scaled down client size, not the texture size.

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> scene_qpainter.cpp:311-313
> +    const QRect target = QRect(toplevel->clientPos(), toplevel->clientSize());
> +    const QRect src = QRect(toplevel->clientPos() + toplevel->clientContentPos(), pixmap->image().size());
> +    painter->drawImage(target, pixmap->image(), src);

do you have a test case in another patch for this? If not I suggest to extend the scene qpainter test to verify the rendering is correct with different scaling

> shell_client.cpp:399-400
> +    //when that changes, this needs adjusting
>      m_clientSize = fbo->size();
> +    markAsMapped();
>      doSetGeometry(QRect(geom.topLeft(), m_clientSize));

why did you swap those two lines?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3494

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161125/8ab8c1c1/attachment.html>