[Differential] [Request, 78 lines] D3493: [effects] Cleanup screenshot effect

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  This change cleans up the screenshot effect a little bit.
  
  - better check whether a screenshot is already being taken
  - proper DBus error messages
  - less duplication of error message strings
  - don't keep the QDBusConnection around

REPOSITORY
  rKWIN KWin

BRANCH
  screenshot-effect-cleanup

REVISION DETAIL
  https://phabricator.kde.org/D3493

AFFECTED FILES
  effects/screenshot/screenshot.cpp
  effects/screenshot/screenshot.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161125/bad85de8/attachment-0001.html>