Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

> On Nov. 22, 2016, 11:05 a.m., David Edmundson wrote:
> > lookandfeel/contents/components/Battery.qml, line 48
> > <https://git.reviewboard.kde.org/r/129528/diff/1/?file=486387#file486387line48>
> >
> >     Given we don't actually care about the value used as long as it's an int as this will be hidden anyway, this can be just:
> >     
> >     percent: pmSource.data["Battery"]["Percent"] || 0
> >     
> >     without a function.

I've changed this and the "Has Battery" (which I'm not sure if it can ever be undefined, but it surely isn't always true). But, I won't be able to test this right now.


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101053
-----------------------------------------------------------


On Nov. 22, 2016, 10:50 a.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129528/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 10:50 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The sddm breeze theme battery icon is trying to access the battery
> percent. In a batteryless system it produces the syslog message:
> Nov 14 22:28:23 samd sddm-greeter[3210]: file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to assign [undefined] to int
> 
> Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
> 
> Debian-Bug: https://bugs.debian.org/844194
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/Battery.qml c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 
> 
> Diff: https://git.reviewboard.kde.org/r/129528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161122/3244affa/attachment.html>