Review Request 129436: Check for metadata validty in settingsFileChanged

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129436/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 4:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 284dddb0f38f43211501890ec2f63db8177dd408 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

settingsFileChanged is called if the plugin metadata file changes, and
reloads the theme if the version changes.

However, if the metadata file now doesn't exist we need to check before
calling .version() otherwise it will assert.

If it doesn't exist, we want to reload the theme so that it will load
the correct thing.

BUG: 372651


Diffs
-----

  src/plasma/private/theme_p.cpp 0f3662e8f58c8cccdf9af2b8cf6878f5f0cef10b 

Diff: https://git.reviewboard.kde.org/r/129436/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161122/36c5e404/attachment.html>