Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests
Bhushan Shah
bhush94 at gmail.com
Mon Nov 21 14:52:31 UTC 2016
> On Nov. 21, 2016, 8:19 p.m., Marco Martin wrote:
> > autotests/mockdepresolver/CMakeLists.txt, line 3
> > <https://git.reviewboard.kde.org/r/129520/diff/1/?file=486366#file486366line3>
> >
> > if qstandardpath is in test mode, would findExecutable() search in .qttest as well?
We are not using findExecutable for searching it, and also .qttest is just for config/data.. and not supposed to be used to install executable.
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129520/#review101023
-----------------------------------------------------------
On Nov. 21, 2016, 7:58 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129520/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 7:58 p.m.)
>
>
> Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Marco Martin.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> This works in quite simple way,
>
> if provided dep url is, mock://validdep it passes
> if provided dep url is, mock://invaliddep it fails
>
> Also adds test cases for testing valid dep and invalid deps.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 2d8b4f5
> autotests/data/testpackagesdep/metadata.json 23da407
> autotests/data/testpackagesdepinvalid/contents/ui/main.qml PRE-CREATION
> autotests/data/testpackagesdepinvalid/metadata.json PRE-CREATION
> autotests/data/testpackagesdepinvalid/testpackagesdepinvalid.testappdataxml PRE-CREATION
> autotests/mockdepresolver/CMakeLists.txt PRE-CREATION
> autotests/mockdepresolver/main.cpp PRE-CREATION
> autotests/querytest.cpp 4186a0b
> src/kpackage/private/packagejobthread.cpp 90016d8
>
> Diff: https://git.reviewboard.kde.org/r/129520/diff/
>
>
> Testing
> -------
>
> tests pass, and moar coverage
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161121/b7d85ca6/attachment-0001.html>
More information about the Plasma-devel
mailing list