Review Request 129519: Improve autotests for kpackage

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129519/#review101011
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Nov. 21, 2016, 1:34 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129519/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 1:34 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> There are multiple changes in this,
> 
> a) Previously it used to install all packages in one go and then just verify number. now this tries to do it step by step.
> b) Added testcase for invalid metadata
> c) This tries to install the package with dependencies specified, which as expected would fail. One would need to mock dep resolver for testcases. (I will address this in next patch)
> 
> 
> Diffs
> -----
> 
>   autotests/data/testinvalidmetadata/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testinvalidmetadata/metadata.json PRE-CREATION 
>   autotests/data/testpackagesdep/metadata.json a634d9d 
>   autotests/querytest.h 6628eff 
>   autotests/querytest.cpp 7765c7f 
> 
> Diff: https://git.reviewboard.kde.org/r/129519/diff/
> 
> 
> Testing
> -------
> 
> make test works, and coverage is also bit up now.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161121/ba0415fb/attachment.html>