Review Request 129298: KPackage dependencies support

[Bhushan Shah]

> On Nov. 21, 2016, 9:34 a.m., Bhushan Shah wrote:
> > src/kpackage/private/packagejobthread.cpp, line 190
> > <https://git.reviewboard.kde.org/r/129298/diff/2/?file=485657#file485657line190>
> >
> >     This can't (and doesn't, as evident by failing test on CI) work on CI for two reasons
> >     
> >     1) kpackagehandlers are installed by frameworksintegration
> >     
> >     2) Every package building on CI have differnt prefix, so CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 for kpackage is not same as one for frameworks.
> >     
> >     Possible solution is to mock the resolveHandler for autotests, so that this framework's autotests are functional without depending on other packages.

Oh actually, failure is totally different and I've fixed that in http://commits.kde.org/kpackage/cf06b94820768fddda2d6ab544220dcccb999137

However, my comment for this code not being functional on CI still stands, if we ever want to autotest this specific code, it can't happen due to two points mentioned above.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129298/#review100996
-----------------------------------------------------------


On Nov. 20, 2016, 4:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129298/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2016, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Makes it possible to specify components to be installed together with a KPackage. They will be specified by a url, we'll have handlers for any kind, making reasonably extensible and doesn't tie us to a technology.
> 
> See RR in frameworksintegration for kns and appstream&packagekit: https://git.reviewboard.kde.org/r/129419/
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 395b16e 
>   autotests/data/testpackagesdep/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testpackagesdep/metadata.json PRE-CREATION 
>   autotests/data/testpackagesdep/testpackagesdep.testappdataxml PRE-CREATION 
>   src/kpackage/config-package.h.cmake 61f2f0c 
>   src/kpackage/private/packagejobthread.cpp 0a0cc01 
>   src/kpackage/private/packagejobthread_p.h 1babf0b 
> 
> Diff: https://git.reviewboard.kde.org/r/129298/diff/
> 
> 
> Testing
> -------
> 
> Can install packages with RR 129419
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161121/763a2cad/attachment.html>