[Differential] [Commented On] D3361: Support multiple event types in X11EventFilter

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in x11eventfilter.cpp:58
> m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector<int> constructor?

no, it cannot be empty. just two lines above there is a check for m_eventTypes having exactly one element.

REPOSITORY
  rKWIN KWin

BRANCH
  x11-event-filter-multiple-types

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161116/514d96d8/attachment.html>