[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.
xuetianweng (Xuetian Weng)
noreply at phabricator.kde.org
Tue Nov 15 22:55:42 UTC 2016
xuetianweng created this revision.
xuetianweng added reviewers: mart, hein, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
For natgeoprovider, since the page it can be accepted by QXmlStreamReader
to get required content, we simple parse it as XML (HTML is NOT necessarily
valid XML).
For noaaprovider, QXmlStreamReader will hit an error in the middle of parsing
so we use regular expression to extract the url.
TEST PLAN
Manually test with plasmashell
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3372
AFFECTED FILES
CMakeLists.txt
dataengines/potd/CMakeLists.txt
dataengines/potd/natgeoprovider.cpp
dataengines/potd/natgeoprovider.h
dataengines/potd/noaaprovider.cpp
dataengines/potd/noaaprovider.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: xuetianweng, mart, hein, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161115/0b3cdde5/attachment.html>
More information about the Plasma-devel
mailing list