[Differential] [Commented On] D3341: add connector name to screen model
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Tue Nov 15 13:00:33 UTC 2016
graesslin added inline comments.
INLINE COMMENTS
> drm_output.cpp:196
>
> + QString connectorName(s_connectorNames[connector->connector_type]);
> + QString modelName;
what if connector_type returns a number we don't know yet? Maybe a find would be better here with a fallback to unknown in case of not found.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3341
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161115/55f7ae07/attachment.html>
More information about the Plasma-devel
mailing list