[Differential] [Commented On] D3341: add connector name to screen model

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> drm_output.cpp:141-159
> +static const char * const s_connector_type_names[] = {
> +    [DRM_MODE_CONNECTOR_Unknown]     = "Unknown",
> +    [DRM_MODE_CONNECTOR_VGA]         = "VGA",
> +    [DRM_MODE_CONNECTOR_DVII]        = "DVI-I",
> +    [DRM_MODE_CONNECTOR_DVID]        = "DVI-D",
> +    [DRM_MODE_CONNECTOR_DVIA]        = "DVI-A",
> +    [DRM_MODE_CONNECTOR_Composite]   = "Composite",

I was more thinking of something like:

  static QMap<int, QByteArray> s_connectorNames = {
      {DRM_MODE_CONNECTOR_Unknown, QByteArrayLiteral("Unknown")},
      {DRM_MODE_CONNECTOR_VGA, QByteArrayLIteral("VGA")},
      // and so on...
  }

sorry for not having bean clear enough. Didn't mean that it should be a C variant.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161115/a4d06c34/attachment-0001.html>