[Differential] [Updated] D3355: add maskArea in panel view

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  One thing to be careful of:
  
  The code in Qt is:
  
    void QWindow::setMask(const QRegion &region)
    {
        Q_D(QWindow);
       if (!d->platformWindow)
            return;
       d->platformWindow->setMask(QHighDpi::toNativeLocalRegion(region, this));
      d->mask = region;
    }
  
  So if you call setMask, before you call show() this will fail.
  
  I'm not sure what order that startup happens, and whether this will break if you have an autohide panel.
  
  You might need to copy the line 
  QWindow::setMask into PanelView::showEvent

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161113/1309da79/attachment.html>