[Differential] [Requested Changes To] D3354: expose panel thickness to the client side

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Panel.qml:75
> +
> +        if (containment.children[0]) {
> +            panelClient = containment.children[0];

We can't do this, it's making an optimistic assumption about the ordering of objects, which is prone to change.

If we go for this, it needs to be in some defined interface like we did for backgroundHints.

I'm not sure quite what yet, I'll discuss back on your main thread.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3354

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161113/54cb1b94/attachment.html>