Review Request 129373: Plasma Framework changes for #129372

[René Fürst]

> On Nov. 10, 2016, 8:58 p.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > I'm not fully sure about this, but let's wait for other Plasma developer feedback :) Especially, since I couldn't yet look at your patch that actually makes use of this API in icontasks.

I've uploaded it to the other review request. 

If those APIs are not added then this basically means that taskmanager needs to be reworked to not use tooltips in order to fix the referenced bug. Basically this calls for a definition of use cases where tooltips should and where tooltips should not be used ;)


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129373/#review100763
-----------------------------------------------------------


On Nov. 10, 2016, 8:47 p.m., René Fürst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129373/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 8:47 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Plasma Framework changes for #129372
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.h d38c49b 
>   src/declarativeimports/core/tooltip.cpp ffe1064 
>   src/declarativeimports/core/tooltipdialog.h d4e0ff0 
>   src/declarativeimports/core/tooltipdialog.cpp 28ba9be 
> 
> Diff: https://git.reviewboard.kde.org/r/129373/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Fürst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161112/bf6631ef/attachment-0001.html>