Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code
Luigi Toscano
luigi.toscano at tiscali.it
Fri Nov 11 22:33:42 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128914/#review100794
-----------------------------------------------------------
Ship it!
I think it's safe enough to import it. There is enough time before the freeze of Plasma 5.9 (more than one month) to fix it in case of problems.
- Luigi Toscano
On Nov. 11, 2016, 4:38 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128914/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2016, 4:38 p.m.)
>
>
> Review request for Documentation, Localization and Translation (l10n) and Plasma.
>
>
> Repository: kde-cli-tools
>
>
> Description
> -------
>
> doc/kcontrol/filetypes/ splitted from kde-runtime master using https://github.com/ajdruff/git-splits
>
> Not included in build so far, the docbook ismported as it was splitted
>
> To be done next:
> adapt CMakeLists.txt, change dtd to kf5,
> reapply one update done in plasma-desktop
> make co-installable, see https://git.reviewboard.kde.org/r/128912/
> remove this imported kcontrol docbook from plasma-desktop
> adapt scripty to these changes
>
>
> Diffs
> -----
>
> doc/CMakeLists.txt 6987c14
> doc/kcontrol5/CMakeLists.txt PRE-CREATION
> doc/kcontrol5/filetypes/CMakeLists.txt PRE-CREATION
> doc/kcontrol5/filetypes/index.docbook PRE-CREATION
> keditfiletype/filetypes.desktop 76f11cf
>
> Diff: https://git.reviewboard.kde.org/r/128914/diff/
>
>
> Testing
> -------
>
> history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log in kde-runtime master
>
>
> File Attachments
> ----------------
>
> git-log-doc-kcontrol-kio-cli-tools.output
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output
> kde-cli-tools-log-doc.txt
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/436b0736-a2e8-46af-b335-36495b824d20__kde-cli-tools-log-doc.txt
>
>
> Thanks,
>
> Burkhard Lück
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161111/9ba193f7/attachment-0001.html>
More information about the Plasma-devel
mailing list