Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote:
> > If I understand it correctly, the review include two separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation).

Thes are two separate changes, the import + update in one RR, see kio-log-docs.txt -> less trouble with scripty


- Burkhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100778
-----------------------------------------------------------


On Nov. 11, 2016, 9:31 vorm., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2016, 9:31 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -----
> 
>   docs/CMakeLists.txt 350bce3 
>   docs/kcontrol5/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/index.docbook PRE-CREATION 
>   docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cookies/index.docbook PRE-CREATION 
>   docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/netpref/index.docbook PRE-CREATION 
>   docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/proxy/index.docbook PRE-CREATION 
>   docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/smb/index.docbook PRE-CREATION 
>   docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/trash/index.docbook PRE-CREATION 
>   docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/useragent/index.docbook PRE-CREATION 
>   docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
>   src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
>   src/kcms/kio/cache.desktop f0bd261 
>   src/kcms/kio/cookies.desktop f91b5cd 
>   src/kcms/kio/netpref.desktop 963ef3f 
>   src/kcms/kio/proxy.desktop c11451d 
>   src/kcms/kio/smb.desktop c323614 
>   src/kcms/kio/useragent.desktop 856e9cc 
>   src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> -------
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime master
> 
> 
> File Attachments
> ----------------
> 
> git-log-doc-kcontrol.output
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161111/e8e4c0ea/attachment.html>