Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129358/#review100769
-----------------------------------------------------------



unrelated: you could have used phab for the request :-)

I'm not completely sure whether it's a good idea to change the semantics of the method, on the other hand I seem to have added a todo for that in the past.


src/server/surface_interface.h (line 117)
<https://git.reviewboard.kde.org/r/129358/#comment67643>

    "in surface normal"? What do you mean by that?



src/server/surface_interface.cpp (lines 338 - 340)
<https://git.reviewboard.kde.org/r/129358/#comment67644>

    please add a test case to test this condition.



src/server/surface_interface.cpp (line 642)
<https://git.reviewboard.kde.org/r/129358/#comment67645>

    this should also be covered in the autotests


- Martin Gräßlin


On Nov. 10, 2016, 4:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129358/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 4:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> Return SurfaceInterface::size in surface normal co-ordinates
> 
> 
> Diffs
> -----
> 
>   src/server/surface_interface.h de74ef336aa7d17c1bd95ba453b8d4f620e416ec 
>   src/server/surface_interface.cpp 157907210254c550e85d24eaa19637f933872ea7 
> 
> Diff: https://git.reviewboard.kde.org/r/129358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161111/36451745/attachment.html>