[Differential] [Request, 58 lines] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to rKDEPLASMAADDONS Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The former uses native text rendering which respects anti-aliasing and hinting settings. It also automatically follows theme colors.
  Unfortunately it breaks the font.bold binding, so using font.weight here instead.
  
  BUG: 372218
  FIXED-IN: 5.8.4
  
  CHANGELOG: Font rendering in window/desktop switchers now follows anti-aliasing and hinting settings

TEST PLAN
  Verified that all switchers still worked. Also verified that items used plasma colortheme (e.g. white text on dark background on Breeze dark) were properly bolded (initially / when active / always, depending on the layout) and italicized (when minimized).
  
  The QML in there could be significantly cleaned up now that we have TextMetrics and Layouts in QML but this code is 5 years old ;)

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3330

AFFECTED FILES
  desktopswitchers/previews/contents/ui/main.qml
  windowswitchers/big_icons/contents/ui/main.qml
  windowswitchers/compact/contents/ui/main.qml
  windowswitchers/informative/contents/ui/main.qml
  windowswitchers/present_windows/contents/ui/main.qml
  windowswitchers/small_icons/contents/ui/main.qml
  windowswitchers/text/contents/ui/main.qml
  windowswitchers/thumbnails/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161110/02c33369/attachment.html>