[Differential] [Request, 358 lines] D3327: VirtualDesktopGrid operates on VirtualDesktop objects

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Thu Nov 10 13:09:00 UTC 2016


graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, hein.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The VirtualDesktopGrid is ported to the new VirtualDesktop objects. The
  grid consists now of QVector<VirtualDesktop*> rows and a QVector of
  those rows.
  
  This change requires to adjust the code using the VirtualDesktopGrid.
  This mostly affects VirtualDesktopManger. The methods for toLeft, above,
  next, etc are now all operating on VirtualDesktop with the uint variants
  
  - if still present - only delegating to the new method. The Functor
  
  objects are also adjusted, though mostly still providing the old API for
  compatibility.
  
  In KWin core only one now ambiguous call is adjusted (useractions) and
  the desktop grid usage in EffectsHandlerImpl is adjusted. Other usages
  are not yet adjusted and need porting to fully get rid of the old
  uint-based API.

TEST PLAN
  VD test still passes

REPOSITORY
  rKWIN KWin

BRANCH
  vd-grid

REVISION DETAIL
  https://phabricator.kde.org/D3327

AFFECTED FILES
  autotests/test_virtual_desktops.cpp
  effects.cpp
  useractions.cpp
  virtualdesktops.cpp
  virtualdesktops.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, hein
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161110/5377d0ff/attachment.html>


More information about the Plasma-devel mailing list