[Differential] [Commented On] D3292: Revamp Wayland application identification; align Wayland and X11 models

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:375
> +        if (!data.id.isEmpty()) {
> +            KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + data.id),
> +                QStringLiteral("org.kde.libtaskmanager"));

another QStringLiteral missing

> waylandtasksmodel.cpp:395
>  
>          KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + service->storageId()),
> +            QStringLiteral("org.kde.libtaskmanager"));

here as well

> xwindowtasksmodel.cpp:984
> +        if (!data.id.isEmpty()) {
> +            KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + data.id),
> +                QStringLiteral("org.kde.libtaskmanager"));

and here

> xwindowtasksmodel.cpp:1004
> +
> +        KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + service->storageId()),
> +            QStringLiteral("org.kde.libtaskmanager"));

and here

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3292

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161108/b5736155/attachment-0001.html>