[Differential] [Updated] D3292: Revamp Wayland application identification; align Wayland and X11 models

Tue Nov 8 08:41:53 UTC 2016

hein marked 5 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> graesslin wrote in launchertasksmodel.cpp:134
> nitpick: added newline

Intentional - my style tends to involve a lot of whitespace I guess (I personally find it more readable when browsing code).

> graesslin wrote in tasktools.cpp:145
> QLatin1String

Done.

> graesslin wrote in xwindowtasksmodel.cpp:984
> this looks like an unrelated change?

It's documented in the change description though.

> graesslin wrote in xwindowtasksmodel.cpp:985
> QStringLiteral("...")

Done.

> graesslin wrote in xwindowtasksmodel.cpp:1005
> QStringLiteral

Done.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3292

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161108/e5bdacba/attachment-0001.html>