[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3282#61310, @davidedmundson wrote:
  
  > From a conusmer POV it'll be exactly the same.
  >
  > Code wise, it's much more awkward to do the first one as it needs to go through the property(_graphicsObject)<AppletInterface>() malarky.
  
  
  yeah, i kinda wish panelview painted its own framesvg like Dialog..
  
  even if not changing anything about the architecture, I think if even if not 100% technically correct, the api would sound better with the effects property actually replaced with backgroundhits like the applet (or even a drawsownbackground bool, but would prefer actually using backgroundhits). The implmentation would stay as is

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/0cb6dfda/attachment.html>