[Differential] [Commented On] D3211: Ensure that all Effects honour the grab roles correctly

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in kwineffects.h:1551
> 5.8.4

I'll update that prior to pushing. If the change would have been reviewed when I uploaded it, it would have been correct.

> hein wrote in kwineffects.h:2036
> The code in setData() always emits though, not just on a value change?

I'll change to "The signal EffectsHandler::windowDataChanged will be emitted"

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3211

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, broulik
Cc: hein, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/6562aa32/attachment.html>