[Differential] [Request, 134 lines] D3290: Introduce a VirtualDesktop class
graesslin (Martin Gräßlin)
noreply at phabricator.kde.org
Mon Nov 7 10:03:29 UTC 2016
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
This is the first change for a larger virtual desktop refactoring. So
far for X11 virtual desktops are just a number. The current virtual
desktop is a number between 1 and the count of virtual desktops.
Similar a Toplevel is on the virtual desktop by setting the number as a
property.
In the long run we want to change that and allow to have windows on
multiple virtual desktops and also support virtual desktops on Wayland.
On Wayland a virtual desktop will be an object.
As a first step a VirtualDesktop class is introduced which currently is
just a glorifed wrapper around the x11 desktop number. The
VirtualDesktopManager now holds a pointer to the current desktop and the
available desktops are a QVector of VirtualDesktops. The implicit
mapping to counting of desktops is removed. Though the internal API is
still completely count based. In follow up changes this will be turned
into being more and more VirtualDesktop based. At least the Core should
be completely transferred to be VirtualDesktop based instead of uint
based.
TEST PLAN
virtual desktop auto test still passes (test coverage 97 % line,
83 % conditionals)
REPOSITORY
rKWIN KWin
BRANCH
virtual-desktop-refactoring
REVISION DETAIL
https://phabricator.kde.org/D3290
AFFECTED FILES
virtualdesktops.cpp
virtualdesktops.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/469388e7/attachment.html>
More information about the Plasma-devel
mailing list