[Differential] [Updated] D3282: Disable / Enable Effects for a Panel

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything.
  
  I would 100% agree, but the difference between panel and dialog is that dialog draws the frame background, panel doesn't.
  
  So "just doing it" still means changing two pieces of code in two repos to be in sync, at which point an explicit API (this patch) is probably the cleaner option.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3282

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/c300edcc/attachment.html>