[Differential] [Commented On] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> xwindowtasksmodel.cpp:490-499
> +    if (!desktopFile.isEmpty()) {
> +        KService::Ptr service = KService::serviceByStorageId(desktopFile);
> +
> +        if (service) {
> +            return QUrl::fromLocalFile(service->entryPath());
> +        }
> +

In KWin we also ensure that the desktopFile ends with .desktop prior to passing to KDesktopFile:

  
  QString desktopFile = QString::fromUtf8(m_desktopFileName);
  if (!desktopFile.endsWith(QLatin1String(".desktop"))) {
      desktopFile.append(QLatin1String(".desktop"));
  }

The desktoFileName is without the .desktop suffix.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3262

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161107/ff34c29b/attachment.html>