Review Request 129276: Make sure we're looking both for json and desktop metadata

Michael Stemle themanchicken at gmail.com
Sun Nov 6 06:06:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129276/#review100625
-----------------------------------------------------------




shell/scripting/scriptengine_v1.cpp (line 527)
<https://git.reviewboard.kde.org/r/129276/#comment67546>

    CASUAL MUSING: It almost seems like we should make a function to resolve this question of whether or not we're using the `.desktop` or the `.json` file.


- Michael Stemle


On Oct. 31, 2016, 11:06 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129276/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 11:06 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> We shouldn't assume metadata is in metadata.desktop
> 
> 
> Diffs
> -----
> 
>   shell/containmentconfigview.cpp 4c9d146 
>   shell/scripting/scriptengine_v1.cpp 23cb839 
>   wallpapers/image/backgroundlistmodel.cpp b30d86d 
>   wallpapers/image/image.cpp 0a65b7d 
> 
> Diff: https://git.reviewboard.kde.org/r/129276/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, all plasma desktop loads properly, even if I remove `.config/plasma-org.kde.plasma.desktop-appletsrc`
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161106/861806a9/attachment.html>


More information about the Plasma-devel mailing list