[Differential] [Accepted] D3209: [Notification Applet] Position dialog before showing it

mart (Marco Martin) noreply at phabricator.kde.org
Fri Nov 4 11:05:41 UTC 2016


mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  tested locally on x11, it seems to still work correctly

INLINE COMMENTS

> notificationshelper.cpp:150
>  
> -    QTimer::singleShot(300, popup, &QWindow::show);
> +    QTimer::singleShot(100, popup, [this, popup] {
> +        // Now we can position the popups properly as the geometry is now known

is the delay by timer still needed?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mck182, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161104/fac9a8a8/attachment.html>


More information about the Plasma-devel mailing list