[Differential] [Request, 7 lines] D3257: Close the system tray on escape - system tray

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A lot of applets have independent handling making escape close the
  expanded representation. However not all of them do.
  
  This leads to both duplicated code and inconsistencies, so we should
  tackle this at the source.
  
  If an applet was already using escape internally it will be accepting
  the event, and so this code will not cause any regressions.
  
  This patch also removes the stackview forwarding events to the active
  child as this doesn't make sense - the active child will already have
  focus and get the key event first, so this just created a recursive
  chain (which Qt was thankfully fixing for us). Removing it is needed for
  this to work.
  
  BUG: 362657

TEST PLAN
  Pressed escape on various applets (e.g plasma-pa)
  Pressed escape on the expander applet list view

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3257

AFFECTED FILES
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161104/2f60ddf4/attachment.html>