[Differential] [Request, 8 lines] D3256: Close popups on escape
davidedmundson (David Edmundson)
noreply at phabricator.kde.org
Fri Nov 4 09:39:53 UTC 2016
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
A lot of applets have independent handling making escape close the
expanded representation. However not all of them do.
This leads to both duplicated code and inconsistencies, so we should
tackle this at the source.
If an applet was already using escape internally it will be accepting
the event, and so this code will not cause any regressions.
CCBUG: 362657
TEST PLAN
Opened a bunch of popups. Pressed escape
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
arcpatch-D3200
REVISION DETAIL
https://phabricator.kde.org/D3256
AFFECTED FILES
desktoppackage/contents/applet/CompactApplet.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161104/2eb1c9a7/attachment.html>
More information about the Plasma-devel
mailing list