[Differential] [Request, 3 lines] D3253: [desktopgrid] Don't manipulate virtual desktop of desktop window

[graesslin (Martin Gräßlin)]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Desktop Grid has a feature that right or middle clicking a window toggles
  the on all desktop state. If that is done for a desktop window, things
  obviously start to fail.
  
  KWin internally allows to change virtual desktop for all windows, even
  for windows like the desktop or docks. Changing in KWin core is not a
  solution.
  
  Thus a special casing in desktop grid is added to disallow the selection
  for desktop windows.
  
  BUG: 372037
  FIXED-IN: 5.8.4

TEST PLAN
  Tried right clicking desktop window and other windows.

REPOSITORY
  rKWIN KWin

BRANCH
  desktop-grid-no-click-desktop

REVISION DETAIL
  https://phabricator.kde.org/D3253

AFFECTED FILES
  effects/desktopgrid/desktopgrid.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161104/dc07247d/attachment.html>