[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  
  
  > I don't like calling virtual methods from a dtor, always a mess.
  
  agreed
  
  > But we can do a private cleanup method and call it from both dtor and unpolish. Would that be OK to you?
  
  yes

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3240

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161103/3d2e351b/attachment.html>